Separate role-specific methods into their own traits #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates
Windowinto two traits:SurfaceandToplevel(subtrait ofSurface).Surfacehandles drawing- and event-related operations, whileToplevelhandles things that only work for toplevel surfaces (maximizing/minimizing, etc.).This architecture allows us to create other subtraits of
Surfaceto represent specific window roles. I have provided theSubviewtrait as a potential example of what this could be used for.