Skip to content

Fix compilation with latest ghostty-vt#3

Open
JNSFilipe wants to merge 6 commits intorwc9u:mainfrom
JNSFilipe:fix-compilation
Open

Fix compilation with latest ghostty-vt#3
JNSFilipe wants to merge 6 commits intorwc9u:mainfrom
JNSFilipe:fix-compilation

Conversation

@JNSFilipe
Copy link
Copy Markdown

Renames 'ghostty_vt.ReadonlyStream' to 'ghostty_vt.TerminalStream' to fix the compilation error in 'src/gterm.zig'. Also updates the documentation in 'CLAUDE.md' to reflect this change.

Copilot AI review requested due to automatic review settings April 1, 2026 11:29
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Emacs libgterm Zig module to compile against the latest ghostty-vt API by adopting the renamed stream type, and aligns project documentation with the new type name.

Changes:

  • Replace ghostty_vt.ReadonlyStream with ghostty_vt.TerminalStream in GtermInstance.
  • Update CLAUDE.md to reference TerminalStream in the “Persistent VT Stream” section.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/gterm.zig Switches the stored VT stream type to ghostty_vt.TerminalStream to match the updated dependency API.
CLAUDE.md Updates documentation to reflect the TerminalStream type name used by the implementation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rwc9u
Copy link
Copy Markdown
Owner

rwc9u commented Apr 13, 2026

Thanks for the PR! There are some nice improvements in here — the dirty tracking, property batching, and timer change all make sense.

That said, this bundles quite a bit under a "fix compilation" title. Would you be open to splitting it up? Something like:

  1. Compilation fix — the ReadonlyStreamTerminalStream rename. Could merge this right away.
  2. Dirty trackingisDirty()/clearDirty(), the new exports, and the elisp refresh loop changes.
  3. Property batching — the put-text-propertyadd-text-properties optimization.
  4. Cleanupsdeclare-function additions, variable renames, timer change.

Splitting them out makes each easier to review, test, and bisect if anything regresses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants