Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Emacs libgterm Zig module to compile against the latest ghostty-vt API by adopting the renamed stream type, and aligns project documentation with the new type name.
Changes:
- Replace
ghostty_vt.ReadonlyStreamwithghostty_vt.TerminalStreaminGtermInstance. - Update
CLAUDE.mdto referenceTerminalStreamin the “Persistent VT Stream” section.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/gterm.zig | Switches the stored VT stream type to ghostty_vt.TerminalStream to match the updated dependency API. |
| CLAUDE.md | Updates documentation to reflect the TerminalStream type name used by the implementation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Owner
|
Thanks for the PR! There are some nice improvements in here — the dirty tracking, property batching, and timer change all make sense. That said, this bundles quite a bit under a "fix compilation" title. Would you be open to splitting it up? Something like:
Splitting them out makes each easier to review, test, and bisect if anything regresses. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames 'ghostty_vt.ReadonlyStream' to 'ghostty_vt.TerminalStream' to fix the compilation error in 'src/gterm.zig'. Also updates the documentation in 'CLAUDE.md' to reflect this change.