Skip to content

Fix bugs in SafeOperator and SafeTxServiceOperator#595

Merged
Uxio0 merged 1 commit intomainfrom
fix-issues
Mar 6, 2026
Merged

Fix bugs in SafeOperator and SafeTxServiceOperator#595
Uxio0 merged 1 commit intomainfrom
fix-issues

Conversation

@Uxio0
Copy link
Member

@Uxio0 Uxio0 commented Mar 6, 2026

  • confirm_message: return False on SafeAPIException from get_message
  • update_version_to_l2: store address strings in safe_cli_info, not lists
  • execute_tx: return False on already-executed and not-enough-signatures paths
  • drain: fix duplicate txs from stale loop variable; use retrieve_nonce()
  • add docker-compose for running tests

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 63aa69489e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@coveralls
Copy link

coveralls commented Mar 6, 2026

Coverage Status

coverage: 89.288% (+0.9%) from 88.35%
when pulling 3f9bab8 on fix-issues
into 9b7e166 on main.

- confirm_message: return False on SafeAPIException from get_message
- update_version_to_l2: store address strings in safe_cli_info, not lists
- execute_tx: return False on already-executed and not-enough-signatures paths
- drain: fix duplicate txs from stale loop variable; use retrieve_nonce()
- add docker-compose for running tests
- update precommit
@Uxio0 Uxio0 merged commit 8e8529d into main Mar 6, 2026
9 checks passed
@Uxio0 Uxio0 deleted the fix-issues branch March 6, 2026 14:54
@github-actions github-actions bot locked and limited conversation to collaborators Mar 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants