chore: don't log stack traces for client errors @W-17954157 #168
Conversation
snacu
changed the title
demianbrecht
left a comment
demianbrecht
left a comment
There was a problem hiding this comment.
i think it'd be worthwhile to keep the seemingly needless logs rather than changing behaviour altogether (silence). otherwise lgtm.
| return self.consumer.secret | ||
| except Exception as e: # noqa | ||
| logger.error( | ||
| "This should never happen, since consumer is already validated" |
There was a problem hiding this comment.
imo it would make sense to remove the error handling here and let it bubble up, but given this log line has been helpful in the past, can the format of it just be changed?
There was a problem hiding this comment.
ok I added back the error message, the content slightly updated in bc69a25
| return self.consumer.rsa_public_key_pem | ||
| except Exception as e: # noqa | ||
| logger.error( | ||
| "This should never happen, since consumer is already validated" |
There was a problem hiding this comment.
ok I added back the error message, the content slightly updated in bc69a25
There was a problem hiding this comment.
should the accompanying test be added back as well?
There was a problem hiding this comment.
added back in efd1ed3, it was slightly modified since now the key is logged and each test uses a random value
W-17954157
registers authenticator - bad credentialse2e test)pyproject.tomlpip installsucceeds with a clean virtualenv