fix bugs to enable key_value cache for generation#36
Open
Kaffaljidhmah2 wants to merge 1 commit intosalesforce:mainfrom
Open
fix bugs to enable key_value cache for generation#36Kaffaljidhmah2 wants to merge 1 commit intosalesforce:mainfrom
Kaffaljidhmah2 wants to merge 1 commit intosalesforce:mainfrom
Conversation
|
Thanks for the contribution! Before we can merge this, we need @Kaffaljidhmah2 to sign the Salesforce Inc. Contributor License Agreement. |
Author
|
I've signed the CLA. Please take a look if is possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
prepare_inputs_for_generation()method is used at each decoding step for auto-regressive generation. The default name for the keyword argument of key-value caches ispast_key_valuesinstead ofpast. Renamingpasttopast_key_valuesfits the Huggingface Transformer interface and enables the key-value cache for the generation.Please refer to https://github.com/huggingface/transformers/blob/main/src/transformers/generation/utils.py#L751.