fix(add repos): Fixed sources_list_dir cleaning#28
Open
spuzirev wants to merge 5 commits intosaltstack-formulas:masterfrom
Open
fix(add repos): Fixed sources_list_dir cleaning#28spuzirev wants to merge 5 commits intosaltstack-formulas:masterfrom
spuzirev wants to merge 5 commits intosaltstack-formulas:masterfrom
Conversation
|
RE: |
Kassec
suggested changes
Jan 31, 2018
Kassec
left a comment
Kassec
left a comment
There was a problem hiding this comment.
Line 37 : why are you supposing url is http ? We may have some keys distributed through a salt:// url.
aboe76
changed the title
aboe76
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
There's problem when you adding repos and use clean_sources_list_d: true they're applied every time.
I've fixed it here. This fix to be honest must be done in salt sources because pkgrepo.managed doesn't care about files it creates. But this fix make this formula working fine.