Prepare salt.utils.process for python 3.14 #68327
Open
+7
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it makes more sense to modify |
Python 3.14 changed multiprocessing method from 'fork' to 'forkserver' on Linux too: python/cpython#84559 This leads to issue similar to when Python 3.8 changed it on Mac OS: saltstack#57742 Change the condition to check for != 'fork' instead of == 'spawn'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Python 3.14 changed multiprocessing method from 'fork' to 'forkserver' on Linux too:
python/cpython#84559
This leads to issue similar to when Python 3.8 changed it on Mac OS: #57742
Change the condition to check for != 'fork' instead of == 'spawn'.
Question: should
salt.util.platform.spawning_platform()be changed instead?forkserverisn't exactly the same asspawn, but it's more similar to it than tofork.What issues does this PR fix or reference?
Related to #68148
Previous Behavior
Fails similar to #57742 on Linux with Python 3.14 (Fedora 43 beta)
New Behavior
Doesn't crash anymore
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes