Conversation
Threated
left a comment
There was a problem hiding this comment.
I am not a huge fan this structure. In order to properly pull this into a library we need to get rid of the globals and the config stuff. I think a better approach is to make this into a cargo workspace and just have one crate be the lib and the other the binary.
Also I would probably create a BeamFileClient or something which contains the BeamClient and has all the methods and so on.
We can have a meeting about this next week.
src/sender/default.rs
Outdated
| .rsplit('.') | ||
| .next() |
There was a problem hiding this comment.
This is wrong and was previously correct. This would incorrectly assume the broker id to be de for app.proxy.broker.de
There was a problem hiding this comment.
let full_to = AppId::new_unchecked(format!( "{}.{}", send_spec.to, beam_id .as_ref() .splitn(3, '.') .nth(2) .expect("Invalid app id") ));
Would this be better?
Extended server feature for deployment and testing