Skip to content

server optimised#10

Closed
Martin1088 wants to merge 12 commits intodevelopfrom
fix/server
Closed

server optimised#10
Martin1088 wants to merge 12 commits intodevelopfrom
fix/server

Conversation

@Martin1088
Copy link
Copy Markdown

Extended server feature for deployment and testing

@Martin1088 Martin1088 requested a review from Threated January 7, 2026 15:55
Copy link
Copy Markdown
Member

@Threated Threated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a huge fan this structure. In order to properly pull this into a library we need to get rid of the globals and the config stuff. I think a better approach is to make this into a cargo workspace and just have one crate be the lib and the other the binary.
Also I would probably create a BeamFileClient or something which contains the BeamClient and has all the methods and so on.
We can have a meeting about this next week.

Comment on lines +14 to +15
.rsplit('.')
.next()
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong and was previously correct. This would incorrectly assume the broker id to be de for app.proxy.broker.de

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let full_to = AppId::new_unchecked(format!( "{}.{}", send_spec.to, beam_id .as_ref() .splitn(3, '.') .nth(2) .expect("Invalid app id") ));
Would this be better?

@Threated Threated closed this Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants