Conversation
TKussel
approved these changes
Mar 30, 2026
Member
TKussel
left a comment
TKussel
left a comment
There was a problem hiding this comment.
I'm not sure I agree with the startup time -- first invocation time trade-off assessment. Let's discuss this further.
| let mut new_count = 0; | ||
| //TODO Check for validity | ||
| for serial in new_certificate_serials { | ||
| let cert_getter = CERT_GETTER.get().unwrap(); |
Member
There was a problem hiding this comment.
does this hold an exclusive lock? If yes, please introduce an additional scope. If not, all good.
Member
Author
There was a problem hiding this comment.
It just gets a shared ref from the OnceCell which should be set at this point. No mutex involved as all methods on dyn GetCerts only need a shared ref.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should improve startup times significantly. In the future I think it would make sense to not fetch all certificates of the beam network at startup but only ever the ones that are needed for sending or receiving a message. This would come at some minor latency cost when the cache is cold but that seems like a good tradeoff.