Only send credentials to spot and prism backends if same-origin#801
Merged
Only send credentials to spot and prism backends if same-origin#801
Conversation
Requests are always same-origin in production when Traefik auth is used since frontend, spot and prism live in the same Docker stack and share auth. This change was made so in local test environments wildcard CORS origin can be used (this would conflict with sending credentials).
timakro
force-pushed
the
credentials-same-origin
branch
from
ace6681 to
1beb6ff
Compare
patrick-skowronek
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requests are always same-origin in production when Traefik auth is used since frontend, spot and prism live in the same Docker stack and share auth. This change was made so in local test environments wildcard CORS origin can be used (this would conflict with sending credentials).
Description
Related Issue
How Has This Been Tested?