test: unit tests for get-account-info #489
Conversation
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Changes requested ❌
Reviewed everything up to 441fb6a in 2 minutes and 37 seconds. Click for details.
- Reviewed
141lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. packages/solana-client/test/get-account-info.test.ts:12
- Draft comment:
Consider using lowerCamelCase (e.g. accountInfo) for plain objects instead of PascalCase (AccountInfo), which is typically reserved for classes or constructors. - Reason this comment was not posted:
Confidence changes required:33%<= threshold50%None
Workflow ID: wflow_TUCarj6A2Cfkm1eU
You can customize 
| } as unknown as SolanaClient | ||
|
|
||
| // ACT & ASSERT | ||
| expect(() => |
There was a problem hiding this comment.
Check if getAccountInfo throws synchronously for invalid addresses. In other tests, it returns a promise (using await). If getAccountInfo is always async, consider using await expect(...).rejects.toThrow() for consistency.
| const mockSend = vi.fn().mockResolvedValue(AccountInfo) | ||
| const mockGetAccountInfo = vi.fn().mockReturnValue({ send: mockSend }) | ||
| const mockClient = { | ||
| rpc: { | ||
| getAccountInfo: mockGetAccountInfo, | ||
| }, | ||
| } as unknown as SolanaClient |
There was a problem hiding this comment.
We should mock only what's needed but create the actual client https://vitest.dev/guide/mocking.html
| const result = await getAccountInfo(mockClient, { address: testAddress }) | ||
|
|
||
| // ASSERT | ||
| expect(result).toEqual(AccountInfo) |
There was a problem hiding this comment.
This is not very useful because you are just testing the mock. What else can we assert here?
2 participants
Description
Issue #379
Screenshots / Video
Checklist
Important
Add unit tests for
getAccountInfoto cover expected and unexpected behaviors, including error handling.getAccountInfoinget-account-info.test.ts.This description was created by
for 441fb6a. You can customize this summary. It will automatically update as commits are pushed.