Update to Wavespectra 4.3.0 #386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 14526635351Details
💛 - Coveralls |
cmichelenstrofer
requested changes
Apr 17, 2025
michaelcdevin
pushed a commit
to michaelcdevin/WecOptTool
that referenced
this pull request
Jun 18, 2025
* compare waves from wavespectra * Remove extra wave functions and update tutorials * Update test waves * Revert nrealizations * Require wavespectra 4.0+ * Update to new version of mambaforge * Revert mambaforge * Use wavespectra for tests * Fix variable input * Remove direction message
michaelcdevin
pushed a commit
to michaelcdevin/WecOptTool
that referenced
this pull request
Jun 18, 2025
* compare waves from wavespectra * Remove extra wave functions and update tutorials * Update test waves * Revert nrealizations * Require wavespectra 4.0+ * Update to new version of mambaforge * Revert mambaforge * Use wavespectra for tests * Fix variable input * Remove direction message
michaelcdevin
pushed a commit
to michaelcdevin/WecOptTool
that referenced
this pull request
Jun 18, 2025
* compare waves from wavespectra * Remove extra wave functions and update tutorials * Update test waves * Revert nrealizations * Require wavespectra 4.0+ * Update to new version of mambaforge * Revert mambaforge * Use wavespectra for tests * Fix variable input * Remove direction message
jtgrasb
added a commit
to jtgrasb/WecOptTool
that referenced
this pull request
Aug 20, 2025
* compare waves from wavespectra * Remove extra wave functions and update tutorials * Update test waves * Revert nrealizations * Require wavespectra 4.0+ * Update to new version of mambaforge * Revert mambaforge * Use wavespectra for tests * Fix variable input * Remove direction message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves #154 by removing functions from the waves class and instead uses the latest version of wavespectra to generate the spectrum and wave energy density array,
efth. Theomnidirectional_spectrum,spectrum,pierson_moskowitz_spectrum,jonswap_spectrum,spread_cos2s,general_spectrum,pierson_moskowitz_paramsare all now handled by wavespectra. The testing for these functions has also been removed.Note that wavespectra's frequency spectrum creation methods leave off direction, but I added a check to add it in when creating the wave elevation and instructions for how to add it in manually for the pioneer tutorial.