Skip to content

Conversation

@jtgrasb
Copy link
Collaborator

@jtgrasb jtgrasb commented Jan 28, 2025

After merging #390, the "update environment" step of the tests ran and found an error. Wavespectra is not yet compatible with 3.13. To fix this, this PR reverts back to python 3.12 (still an update from previous version (3.11)).

@coveralls
Copy link

coveralls commented Jan 28, 2025

Pull Request Test Coverage Report for Build 13041181782

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on python-3.13 at 94.583%

Totals Coverage Status
Change from base Build 13017624886: 94.6%
Covered Lines: 2776
Relevant Lines: 2935

💛 - Coveralls

@jtgrasb jtgrasb changed the title Try specifying subversion Try specifying sub-version Jan 28, 2025
@jtgrasb jtgrasb changed the title Try specifying sub-version Revert to Python 3.12 Jan 28, 2025
@jtgrasb jtgrasb merged commit 42721d6 into sandialabs:dev Jan 29, 2025
10 checks passed
michaelcdevin pushed a commit to michaelcdevin/WecOptTool that referenced this pull request Jun 18, 2025
* Try specifying subversion

* Test new cache

* revert to 3.12

* Revert comment back to normal
michaelcdevin pushed a commit to michaelcdevin/WecOptTool that referenced this pull request Jun 18, 2025
* Try specifying subversion

* Test new cache

* revert to 3.12

* Revert comment back to normal
michaelcdevin pushed a commit to michaelcdevin/WecOptTool that referenced this pull request Jun 18, 2025
* Try specifying subversion

* Test new cache

* revert to 3.12

* Revert comment back to normal
jtgrasb added a commit to jtgrasb/WecOptTool that referenced this pull request Aug 20, 2025
* Try specifying subversion

* Test new cache

* revert to 3.12

* Revert comment back to normal
jtgrasb added a commit to jtgrasb/WecOptTool that referenced this pull request Aug 20, 2025
* Try specifying subversion

* Test new cache

* revert to 3.12

* Revert comment back to normal
jtgrasb added a commit to jtgrasb/WecOptTool that referenced this pull request Sep 3, 2025
* Try specifying subversion

* Test new cache

* revert to 3.12

* Revert comment back to normal
jtgrasb added a commit to jtgrasb/WecOptTool that referenced this pull request Oct 21, 2025
* Update CONTRIBUTING.md to indicate PRs should be to the new `dev` branch

* Update RELEASING.md to reflect new workflow with the `dev` branch

* update docstrings (sandialabs#326)

* damping naming and consistently change radiation damping (sandialabs#328)

* issue 321 fd_to_td() bug (sandialabs#329)

* bug bix : DC and Nyquist frequency should not be devided by two before ifft

* Changed td_to_fd to scale single sided frequency components rather than TD signal

* minor bug fix from issue332 sandialabs#332

* nodf -> ndof (sandialabs#334)

* add DOI for Daniel's paper (sandialabs#336)

* Lower tolerance for new test to fix CI failing occasionally

* hyperlinks no longer have formatting, plus other small adjustments (sandialabs#348)

* Merge to dev, not main (sandialabs#349)

* Dev version of documentation site (sandialabs#347)

* added initial file changes based on sphinx_multiversion docs and WEC-Sim implementation

* removed sphinx-multiversion since it is no longer supported and made manual multiversion

* now uses absolute paths, commented out linkcheck for debugging

* fixed docstring errors in utilities module

* updating files again that somehow got reverted

* fixing path in conf.py

* don't run tutorials (will revert later)

* handle file moves correctly, fixed if statement to make other versions appear

* fixed two bugs in versions template

* reverted temp changes, changes latest to main

* switched latest to main

* main branch now in root directory of pages

* fixed URLs with change from last commit

* make other branches visible before building

* switched main branch tag for more testing

* fixed typo

* switched dev branch to an existing branch

* renamed main to latest, changed version.html file name to avoid confusion

* added prints about moving files so Sphinx output isn't misleading

* fixed typo with quotations

* changed versions.html name back because that broke things I guess

* modified contributing documentation to reflect changes

* add logic to remove duplicate 'latest' branch

* Fixed pathing when already on latest

* remove typo

* Troubleshooting complete, switching back to correct branches for deployment

* Removed extra word in docstring

* removed redundant function

* fixed pathing so returns to same file (and fixes tutorial/API docs)

* changed latest branch for demonstration

* switched back latest branch for deployment

* updated with new Capytaine docs URL

* Add warnings when adding inertia and hydrostatic stiffness automatically (sandialabs#346)

* CI workflow cleanup (sandialabs#352)

* removed conda environment from workflows since newer capytaine/wavespectra work with Windows

* fixed unnecessary capitalization

* still create CI conda environment to fix Mac environment failures

* added conda env fully back in, push workflow deploys docs, split PR workflow

* conda environment activates again

* mambaforge instead of miniforge

* manual cache reset

* reset to older version of setup-miniconda to troubleshoot

* Updated workflows to newest Python version and changed references to supported versions (sandialabs#390)

Co-authored-by: jtgrasb <[email protected]>

* Revert to Python 3.12 (sandialabs#394)

* Try specifying subversion

* Test new cache

* revert to 3.12

* Revert comment back to normal

* use dev for docs and restrict sphinx (sandialabs#396)

* Remove Sphinx version requirement (sandialabs#409)

* v3.0.3

* v3.1

* Trying to convert tutorial 1

* Convert to jax progress

* post-processing

* clear outputs

* wavebot tutorial running

* wavebot tutorial running

* Update to jax and numpy

* Revert wavebot execution count

* update pyproject.toml

* Specify jax version for mac

* try jaxlib

* no jaxlib

* add jax to environment manually

* add jaxlib to env

* ad jaxlib to pyproject

* install jax manually for macos

* conda init

* install jax and jaxlib on macos

* try arm64

* remove arm

* make core optimization jittable

* try pinning jax version

* revert previous

* install entirely w. pip

* Add verbose outputs to testing

* editable mode

* no mamba

* editable mode

* update random inputs

* remove cache environment

* use pytest-cov

* remove cache clear

* Fix push.yml

---------

Co-authored-by: Carlos A. Michelén Ströfer <[email protected]>
Co-authored-by: Ryan Coe <[email protected]>
Co-authored-by: Daniel Gaebele <[email protected]>
Co-authored-by: Michael Devin <[email protected]>
Co-authored-by: mcdevin <[email protected]>
jtgrasb added a commit to jtgrasb/WecOptTool that referenced this pull request Oct 21, 2025
* Update CONTRIBUTING.md to indicate PRs should be to the new `dev` branch

* Update RELEASING.md to reflect new workflow with the `dev` branch

* update docstrings (sandialabs#326)

* damping naming and consistently change radiation damping (sandialabs#328)

* issue 321 fd_to_td() bug (sandialabs#329)

* bug bix : DC and Nyquist frequency should not be devided by two before ifft

* Changed td_to_fd to scale single sided frequency components rather than TD signal

* minor bug fix from issue332 sandialabs#332

* nodf -> ndof (sandialabs#334)

* add DOI for Daniel's paper (sandialabs#336)

* Lower tolerance for new test to fix CI failing occasionally

* hyperlinks no longer have formatting, plus other small adjustments (sandialabs#348)

* Merge to dev, not main (sandialabs#349)

* Dev version of documentation site (sandialabs#347)

* added initial file changes based on sphinx_multiversion docs and WEC-Sim implementation

* removed sphinx-multiversion since it is no longer supported and made manual multiversion

* now uses absolute paths, commented out linkcheck for debugging

* fixed docstring errors in utilities module

* updating files again that somehow got reverted

* fixing path in conf.py

* don't run tutorials (will revert later)

* handle file moves correctly, fixed if statement to make other versions appear

* fixed two bugs in versions template

* reverted temp changes, changes latest to main

* switched latest to main

* main branch now in root directory of pages

* fixed URLs with change from last commit

* make other branches visible before building

* switched main branch tag for more testing

* fixed typo

* switched dev branch to an existing branch

* renamed main to latest, changed version.html file name to avoid confusion

* added prints about moving files so Sphinx output isn't misleading

* fixed typo with quotations

* changed versions.html name back because that broke things I guess

* modified contributing documentation to reflect changes

* add logic to remove duplicate 'latest' branch

* Fixed pathing when already on latest

* remove typo

* Troubleshooting complete, switching back to correct branches for deployment

* Removed extra word in docstring

* removed redundant function

* fixed pathing so returns to same file (and fixes tutorial/API docs)

* changed latest branch for demonstration

* switched back latest branch for deployment

* updated with new Capytaine docs URL

* Add warnings when adding inertia and hydrostatic stiffness automatically (sandialabs#346)

* CI workflow cleanup (sandialabs#352)

* removed conda environment from workflows since newer capytaine/wavespectra work with Windows

* fixed unnecessary capitalization

* still create CI conda environment to fix Mac environment failures

* added conda env fully back in, push workflow deploys docs, split PR workflow

* conda environment activates again

* mambaforge instead of miniforge

* manual cache reset

* reset to older version of setup-miniconda to troubleshoot

* Updated workflows to newest Python version and changed references to supported versions (sandialabs#390)

Co-authored-by: jtgrasb <[email protected]>

* Revert to Python 3.12 (sandialabs#394)

* Try specifying subversion

* Test new cache

* revert to 3.12

* Revert comment back to normal

* use dev for docs and restrict sphinx (sandialabs#396)

* Remove Sphinx version requirement (sandialabs#409)

* v3.0.3

* v3.1

* Trying to convert tutorial 1

* Convert to jax progress

* post-processing

* clear outputs

* wavebot tutorial running

* wavebot tutorial running

* Update to jax and numpy

* Revert wavebot execution count

* update pyproject.toml

* Specify jax version for mac

* try jaxlib

* no jaxlib

* add jax to environment manually

* add jaxlib to env

* ad jaxlib to pyproject

* install jax manually for macos

* conda init

* install jax and jaxlib on macos

* try arm64

* remove arm

* make core optimization jittable

* try pinning jax version

* revert previous

* install entirely w. pip

* Add verbose outputs to testing

* editable mode

* no mamba

* editable mode

* update random inputs

* remove cache environment

* use pytest-cov

* remove cache clear

* Fix push.yml

---------

Co-authored-by: Carlos A. Michelén Ströfer <[email protected]>
Co-authored-by: Ryan Coe <[email protected]>
Co-authored-by: Daniel Gaebele <[email protected]>
Co-authored-by: Michael Devin <[email protected]>
Co-authored-by: mcdevin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants