Skip to content

Conversation

cmichelenstrofer
Copy link
Member

@cmichelenstrofer cmichelenstrofer commented Sep 30, 2025

Description

Fixes #439

Type of PR

  • Bug fix
  • New feature
  • Documentation
  • Other: (specify)

Checklist for PR

Additional details

Include any relevant context and describe any validation and verification efforts.

@cmichelenstrofer cmichelenstrofer changed the base branch from main to dev September 30, 2025 19:56
@coveralls
Copy link

Pull Request Test Coverage Report for Build 18383473295

Details

  • 76 of 79 (96.2%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.08%) to 93.899%

Changes Missing Coverage Covered Lines Changed/Added Lines %
wecopttool/core.py 1 2 50.0%
tests/test_integration.py 75 77 97.4%
Totals Coverage Status
Change from base Build 17801806891: 0.08%
Covered Lines: 2832
Relevant Lines: 3016

💛 - Coveralls

@jtgrasb
Copy link
Collaborator

jtgrasb commented Oct 9, 2025

Just reviewed this and made a small update to the kinematics matrix to get the tests to pass. Looks ready to merge.

@cmichelenstrofer cmichelenstrofer merged commit 34d2d88 into sandialabs:dev Oct 9, 2025
10 checks passed
jtgrasb added a commit to jtgrasb/WecOptTool that referenced this pull request Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: WEC.from_impedance doesn't seem to work for more than one DOF

3 participants