Only Default To Fastcontext When It's Known To Work #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insertinterestingnamehere
force-pushed
the
ppc
branch
from
27d344b to
8ab736f
Compare
|
Okay, the CI failures are unrelated. They appear to be caused by some kind of change upstream. I'm debugging them elsewhere. |
insertinterestingnamehere
force-pushed
the
ppc
branch
2 times, most recently
from
aa8d641 to
a226a73
Compare
insertinterestingnamehere
force-pushed
the
ppc
branch
from
a226a73 to
6569675
Compare
insertinterestingnamehere
merged commit 0b412c2
into
sandialabs:main
348 of 368 checks passed
|
Thanks for the quick turnaround on this, Ian! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by a bug on a "ppc64le" machine. It turned out that the old build system was using the fallback implementation on that platform which was hiding the fact that our context swap code doesn't actually work there. We're only nominally committed to supporting any kind of powerpc platform whatsoever so this just makes the new build system fall back to the system swapcontext on that platform. We may just fix the little-endian bug or just drop support for that platform later, but this at least maintains the baseline of working on that platform for now.