installer-tests: Use a more specific cleanup function#2650
Open
paulproteus wants to merge 1 commit intomasterfrom
Open
installer-tests: Use a more specific cleanup function#2650paulproteus wants to merge 1 commit intomasterfrom
paulproteus wants to merge 1 commit intomasterfrom
Conversation
Earlier, I had added purging postfix to cleanup for all tests. However, not all of our test VMs run Debian, so this was a pretty silly idea in hindsight. This Sandstorm commit uses a new cleanup function defined here: paulproteus/stodgy-tester@51ed3de so that Postfix is successfully removed from the VM to avoid disruption to other installer-tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Earlier, I had added purging postfix to cleanup for all tests. However, not all of our test VMs run Debian,
so this was a pretty silly idea in hindsight.
This Sandstorm commit uses a new cleanup function defined here:
paulproteus/stodgy-tester@51ed3de
so that Postfix is successfully removed from the VM to avoid disruption to
other installer-tests.
Testing done: Currently running this on
asheeshdev.sandcats.iowith the latest version ofstodgy-tester. Once that passes, I'll merge this, and re-enable https://build.sandstorm.io/job/Sandstorm-installer/ and do a test build on Jenkins to make sure all is well.