-
Notifications
You must be signed in to change notification settings - Fork 499
chore(core): set unpublish as the primary action for published documents #11308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
🧪 E2E Preview environment🔑 Environment Variables for Local TestingThis is the preview URL for the E2E tests: https://e2e-studio-ksbpg1atz.sanity.dev To run the E2E tests locally, you can use the following environment variables, then run 💬 Remember to build the project first with |
📊 Playwright Test ReportThis report contains test results, including videos of failing tests. |
| const sortedActions = [...documentActions].sort((a, b) => { | ||
| if (a.action === 'unpublish') return -1 | ||
| if (b.action === 'unpublish') return 1 | ||
| return 0 | ||
| }) | ||
| return Array.from(new Set([...prevActions, ...sortedActions])) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should also remove the Publish action from the published document
⚡️ Editor Performance ReportUpdated Fri, 28 Nov 2025 12:30:18 GMT
Detailed information🏠 Reference resultThe performance result of
🧪 Experiment resultThe performance result of this branch
📚 Glossary
|
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
stipsan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense!
c77f905 to
b366f89
Compare
Description
The primary action for the
publisheddocument is the Publish, which doesn't make sense because you cannot publish a published document.This PR updates the primary action to be the Unpublish action instead.
What to review
Testing
Notes for release
Makes Unpublish the primary action for Published documents