-
Notifications
You must be signed in to change notification settings - Fork 1
feat: implement real calls for shared worker #614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ryanbonial
wants to merge
11
commits into
08-19-feat_core_add_connection_to_query_store
Choose a base branch
from
rb_09_04_implement_real_shared_worker
base: 08-19-feat_core_add_connection_to_query_store
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat: implement real calls for shared worker #614
ryanbonial
wants to merge
11
commits into
08-19-feat_core_add_connection_to_query_store
from
rb_09_04_implement_real_shared_worker
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for GitHub.
|
3641980
to
20914f3
Compare
Add query execution to SharedWorker with @sanity/client integration Update Dashboard to return actual query results instead of placeholder data Modify query forwarding to store results in local query state - Add caching mechanism with stable query keys - Implement proper response handling for both subscription and observable patterns - Fix TypeScript errors and normalize query options with perspective This connects the iframe query forwarding to actual SharedWorker-based query execution and caching, completing the core SharedWorker functionality.
5018271
to
c362b7d
Compare
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
* chore(kitchensink): move to Sanity Sandbox organization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implemented cross-iframe query forwarding between Dashboard and SDK apps using SharedWorker. This allows SDK apps running in iframes to execute queries through the parent Dashboard application, enabling centralized query execution and caching.
The implementation uses a combination of:
What to review
Testing
Tested by:
Fun gif