feat: support arbitrary sources in useQuery #633
Draft
+198
−126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This was referenced Sep 24, 2025
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Sep 24, 2025
judofyr
force-pushed
the
holm/query-source
branch
from
be8858e to
f889a92
Compare
judofyr
force-pushed
the
holm/query-source
branch
from
f889a92 to
739eb9c
Compare
This was referenced Sep 25, 2025
judofyr
force-pushed
the
holm/dataset-bound
branch
from
9a3e862 to
7029e15
Compare
judofyr
force-pushed
the
holm/query-source
branch
from
739eb9c to
661c187
Compare
judofyr
force-pushed
the
holm/query-source
branch
from
661c187 to
5b56379
Compare
This contains a non-breaking change to `useQuery` (and other hooks which uses this under the hood) of accepting a `source` parameter. This can be used to query datasets which are not part of the current context. However, this has lead to some breaking changes to the `core` package: - The QueryOptions no longer takes an _optional_ projectId/dataset, but rather a _required_ `source`. This will always represent the resource we'll be querying. - The same applies to `perspective`. This is part of the work of decoupling the perspective setting from the SanityInstace. - However, since we still want `useQuery` to have the same options we've now introduced a new UseQueryOptions.
judofyr
force-pushed
the
holm/query-source
branch
from
5b56379 to
51c04f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This contains a non-breaking change to
useQuery(and other hooks which uses this under the hood) of accepting asourceparameter. This can be used to query datasets which are not part of the current context.However, this has lead to some breaking changes to the
corepackage:source. This will always represent the resource we'll be querying.perspective. This is part of the work of decoupling the perspective setting from the SanityInstace.useQueryto have the same options we've now introduced a new UseQueryOptions. This could potentially be considered a breaking change.What to review
Testing
Fun gif