test: removing mocking of useSanityInstance hook #645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This is easily replaced by actually placing a real instance in the context.
judofyr
force-pushed
the
holm/avoid-sanity-instance-mock
branch
from
54070fc to
3408904
Compare
binoy14
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Many of the React tests were mocking the
useSanityInstancehook. This is unfortunate because it depends on internals (the fact that it invokes that specific hook) which we might want to change. This replaces all of these mocks by using theResourceProvider. This makes the test closer to the public API and less likely to have to change if we want to change the internals.What to review
Testing
N/A.
Fun gif