-
Notifications
You must be signed in to change notification settings - Fork 4
fix(ci): Remove PHP 7.4 and update to single PHP 8.2 setup #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): Remove PHP 7.4 and update to single PHP 8.2 setup #144
Conversation
|
Thanks for the PR 😍 How to test these changes in your application
Diff between recipe versionsIn order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes. |
|
We should keep this in sync with symfony which uses 8.1 and 8.2 currently: https://github.com/symfony/recipes/blob/137e34765a384120bc53d16148910f35e5fc9673/.github/workflows/callable-qa.yml#L243-L278 |
|
@alexander-schranz I'll remove skeleton ^5 and add skeleton ^7 (I've seen the error on contrib too) |
|
yes make sense seems like symfony already upgraded to only test against skeleton 6 and 7 |
|
@pocky thx the contrib reuses the same action: https://github.com/schranz-php-recipes/symfony-recipes-php-contrib/blob/main/.github/workflows/qa.yml#L12 |
|
I'm running my own Symfony Flex recipes server with custom PHP recipes (https://github.com/mformono/recipes) and your work has been incredibly helpful. Thanks a lot for your time and effort! |
|
Nice to see that this is also reusable for other cases :) |
Fix errors in pipeline: https://github.com/schranz-php-recipes/symfony-recipes-php/actions/runs/16118506792/job/45478032511