Skip to content

Conversation

@pocky
Copy link
Contributor

@pocky pocky commented Jul 7, 2025

@github-actions
Copy link

github-actions bot commented Jul 7, 2025

Thanks for the PR 😍

How to test these changes in your application

  1. Define the SYMFONY_ENDPOINT environment variable:

    # On Unix-like (BSD, Linux and macOS)
    export SYMFONY_ENDPOINT=https://raw.githubusercontent.com/schranz-php-recipes/symfony-recipes-php/flex/pull-144/index.json
    # On Windows
    SET SYMFONY_ENDPOINT=https://raw.githubusercontent.com/schranz-php-recipes/symfony-recipes-php/flex/pull-144/index.json
  2. Install the package(s) related to this recipe:

    composer req symfony/flex
    composer req 
  3. Don't forget to unset the SYMFONY_ENDPOINT environment variable when done:

    # On Unix-like (BSD, Linux and macOS)
    unset SYMFONY_ENDPOINT
    # On Windows
    SET SYMFONY_ENDPOINT=

Diff between recipe versions

In order to help with the review stage, I'm in charge of computing the diff between the various versions of patched recipes.
I'm going keep this comment up to date with any updates of the attached patch.

@alexander-schranz
Copy link
Member

We should keep this in sync with symfony which uses 8.1 and 8.2 currently: https://github.com/symfony/recipes/blob/137e34765a384120bc53d16148910f35e5fc9673/.github/workflows/callable-qa.yml#L243-L278

@pocky
Copy link
Contributor Author

pocky commented Jul 7, 2025

@alexander-schranz I'll remove skeleton ^5 and add skeleton ^7 (I've seen the error on contrib too)

@pocky pocky force-pushed the fix/php-version branch from f6e3cd3 to 1a49805 Compare July 7, 2025 14:49
@alexander-schranz
Copy link
Member

yes make sense seems like symfony already upgraded to only test against skeleton 6 and 7

@pocky pocky force-pushed the fix/php-version branch from 1a49805 to a845ba2 Compare July 7, 2025 14:51
@pocky pocky force-pushed the fix/php-version branch from a845ba2 to 7a172d8 Compare July 7, 2025 14:54
@alexander-schranz alexander-schranz merged commit 9c4722a into schranz-php-recipes:main Jul 7, 2025
2 checks passed
@alexander-schranz
Copy link
Member

@pocky
Copy link
Contributor Author

pocky commented Jul 7, 2025

I'm running my own Symfony Flex recipes server with custom PHP recipes (https://github.com/mformono/recipes) and your work has been incredibly helpful. Thanks a lot for your time and effort!

@alexander-schranz
Copy link
Member

Nice to see that this is also reusable for other cases :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants