Skip to content

Conversation

@matthewfeickert
Copy link
Member

@matthewfeickert matthewfeickert commented Nov 7, 2025

Description

  • SciPy v1.5.4 is the first SciPy release to have Python 3.9 wheels.
  • Update scipy to v1.5.4 in tests/constraints.txt to enforce the lower bound for the minimum supported dependencies tests.

Checklist Before Requesting Reviewer

  • Tests are passing
  • "WIP" removed from the title of the pull request
  • Selected an Assignee for the PR to be responsible for the log summary

Before Merging

For the PR Assignees:

  • Summarize commit messages into a comprehensive review of the PR
* SciPy v1.5.4 is the first SciPy release to have Python 3.9 wheels.
   - c.f. https://pypi.org/project/scipy/1.5.4/#files
* Update scipy to v1.5.4 in tests/constraints.txt to enforce the
  lower bound for the minimum supported dependencies tests.

* SciPy v1.5.4 is the first SciPy release to have Python 3.9 wheels.
* Update scipy to v1.5.4 in tests/constraints.txt to enforce the lower
  bound for the minimum supported dependencies tests.
@matthewfeickert matthewfeickert self-assigned this Nov 7, 2025
@matthewfeickert matthewfeickert added tests pytest build Changes that affect the build system or external dependencies dependencies Pull requests that update a dependency file labels Nov 7, 2025
@github-project-automation github-project-automation bot moved this to In progress in pyhf v0.8.0 Nov 7, 2025
@matthewfeickert matthewfeickert marked this pull request as ready for review November 7, 2025 22:32
@matthewfeickert
Copy link
Member Author

Minimum supported dependencies workflow check passing on my fork:

image

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the minimum required scipy version from 1.5.2 to 1.5.4 across dependency specifications.

Key changes:

  • Updated scipy minimum version constraint from 1.5.2 to 1.5.4 in both pyproject.toml and tests/constraints.txt

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tests/constraints.txt Updated pinned scipy version for testing from 1.5.2 to 1.5.4
pyproject.toml Updated minimum scipy version requirement from >=1.5.2 to >=1.5.4 in project dependencies

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.23%. Comparing base (0f52681) to head (858b363).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2633   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files          65       65           
  Lines        4190     4190           
  Branches      453      453           
=======================================
  Hits         4116     4116           
  Misses         45       45           
  Partials       29       29           
Flag Coverage Δ
contrib 98.11% <ø> (ø)
doctest 98.23% <ø> (ø)
unittests-3.10 96.42% <ø> (ø)
unittests-3.11 96.42% <ø> (ø)
unittests-3.12 96.42% <ø> (ø)
unittests-3.13 96.42% <ø> (ø)
unittests-3.9 96.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@matthewfeickert matthewfeickert enabled auto-merge (squash) November 7, 2025 23:00
@matthewfeickert matthewfeickert merged commit edc3e9c into scikit-hep:main Nov 7, 2025
27 of 28 checks passed
@matthewfeickert matthewfeickert deleted the build/update-lower-bounds branch November 7, 2025 23:00
@github-project-automation github-project-automation bot moved this from In progress to Done in pyhf v0.8.0 Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Changes that affect the build system or external dependencies dependencies Pull requests that update a dependency file tests pytest

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants