CHORE: Drop support for Python <3.9 and NumPy <1.22 #631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Valentin-Laurent
commented
Mar 27, 2025
Valentin-Laurent
commented
- Remove numpy compatibility modules (_typing.py and _compatibility.py) and correct related imports (hence the number of files modified in this PR)
- Update dependencies in pyproject.toml
- Update dependencies in CI
- Update Migration Guide and README.rst
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR drops support for Python <3.9 and NumPy <1.22 by removing obsolete compatibility modules and updating import statements and dependency configurations.
- Removed the numpy compatibility modules (_typing.py and _compatibility.py) and updated import paths in production and example files.
- Updated CI workflow and dependency versions to reflect the new minimum requirements.
Reviewed Changes
Copilot reviewed 66 out of 68 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| mapie/aggregation_functions.py | Changed NDArray import to use numpy.typing for compliance with NumPy >=1.22. |
| mapie/_typing.py | Removed obsolete compatibility module. |
| mapie/_compatibility.py | Removed compatibility wrappers no longer necessary with NumPy >=1.22. |
| examples/* | Updated multiple examples to import types from numpy.typing instead of mapie._typing. |
| .github/workflows/test.yml | Updated CI configuration to drop Python 3.7/3.8 tests and use numpy-version 1.22.4 for Python 3.9+. |
Files not reviewed (2)
- README.rst: Language not supported
- doc/v1_migration_guide.rst: Language not supported
- Remove numpy compatibility modules (_typing.py and _compatibility.py) and correct related imports (hence the number of files modified in this PR) - Update dependencies in pyproject.toml - Update dependencies in CI - Update Migration Guide and README.rst
Valentin-Laurent
force-pushed
the
v1-bump-minimal-dependencies-versions
branch
from
3608d76 to
8805b0d
Compare
Valentin-Laurent
added a commit
that referenced
this pull request
Apr 2, 2025
- Remove numpy compatibility modules (_typing.py and _compatibility.py) and correct related imports (hence the number of files modified in this PR) - Update dependencies in pyproject.toml - Update dependencies in CI - Update Migration Guide and README.rst
FaustinPulveric
pushed a commit
that referenced
this pull request
Apr 23, 2025
- Remove numpy compatibility modules (_typing.py and _compatibility.py) and correct related imports (hence the number of files modified in this PR) - Update dependencies in pyproject.toml - Update dependencies in CI - Update Migration Guide and README.rst
Valentin-Laurent
added a commit
that referenced
this pull request
Apr 23, 2025
Valentin-Laurent
added a commit
that referenced
this pull request
May 6, 2025
- Remove numpy compatibility modules (_typing.py and _compatibility.py) and correct related imports (hence the number of files modified in this PR) - Update dependencies in pyproject.toml - Update dependencies in CI - Update Migration Guide and README.rst
Valentin-Laurent
added a commit
that referenced
this pull request
May 6, 2025
- Remove numpy compatibility modules (_typing.py and _compatibility.py) and correct related imports (hence the number of files modified in this PR) - Update dependencies in pyproject.toml - Update dependencies in CI - Update Migration Guide and README.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.