Skip to content

Conversation

Copilot
Copy link

@Copilot Copilot AI commented Aug 10, 2025

This PR addresses the improper deprecation of the TimeSeriesRegressor.partial_fit method by:

  1. Updating documentation files to use the new update method instead of the deprecated partial_fit:

    • examples/regression/2-advanced-analysis/plot_timeseries_enbpi.py: Updated method calls and print statements
    • notebooks/regression/ts-changepoint.ipynb: Updated all instances of partial_fit usage in code cells and text
  2. Adding version number to the deprecation warning: The warning now includes "This method will be removed in v1.1." to follow sklearn deprecation guidelines for the next minor version.

  3. Updated test to match the new warning message format.

The partial_fit method has been deprecated for some time but was still being used in documentation examples. The update method provides the same functionality and automatically dispatches to the appropriate internal method based on the chosen strategy (enbpi or aci).

Before:

mapie_enbpi.partial_fit(X_test, y_test)  # Shows deprecation warning without version

After:

mapie_enbpi.update(X_test, y_test)  # Clean, no warnings

All existing functionality is preserved, and the deprecation warning now properly indicates when the method will be removed.

Fixes #699.


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Copy link
Author

Copilot AI commented Aug 10, 2025

@Valentin-Laurent 👋 This repository doesn't have Copilot instructions. With Copilot instructions, I can understand the repository better, work faster and produce higher quality PRs.

I can generate a .github/copilot-instructions.md file for you automatically. Click here to open a pre-filled issue and assign it to me. I'll write the instructions, and then tag you for review.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@Copilot Copilot AI changed the title [WIP] Properly deprecate TimeSeriesRegressor.partial_fit method Properly deprecate TimeSeriesRegressor.partial_fit method Aug 10, 2025
@Copilot Copilot AI requested a review from Valentin-Laurent August 10, 2025 09:53
Copilot finished work on behalf of Valentin-Laurent August 10, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Properly deprecate TimeSeriesRegressor.partial_fit method
2 participants