Move $HOME env variable outside web server's Document root#454
Draft
SlouchyButton wants to merge 2 commits intosclorg:masterfrom
Draft
Move $HOME env variable outside web server's Document root#454SlouchyButton wants to merge 2 commits intosclorg:masterfrom
SlouchyButton wants to merge 2 commits intosclorg:masterfrom
Conversation
Member
|
[test] |
phracek
requested changes
Jul 30, 2024
Member
|
[test-all] |
phracek
reviewed
Aug 1, 2024
Member
phracek
left a comment
phracek
left a comment
There was a problem hiding this comment.
Thanks for this pull request. The change itself LGTM. Let's wait for the tests. Good Job.
Pull Request validationFailed🔴 Approval - missing or changes were requested Success🟢 CI - All checks have passed |
Member
|
[test-all] |
Testing Farm results
|
Member
|
I don't know what is the status here. Let's convert it to Draft. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overwrite $HOME env variable for all supported versions. Default $HOME is directed inside the web server's Document root, which means that applications that save potentially private data to $HOME (e.g. bash's histfile) will save them into a folder accessible outside the container via the web server. This means there is a possibility of leaking the data.
This does not occur in all cases, namely bash won't create a histfile at all, when user sets a different user via
--user=argument inpodman runcommand, as in that case bash doesn't have a permission to write into the $HOME.Fixes: #255