Hotfix/react 18 fixes #9849
Merged
Hotfix/react 18 fixes #9849
+500
−470
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This appears to be a general timing issue. I'm not sure why it shows up as a problem on mobile Safari specifically. Basically, we need to fetch project info in order for the project page to load correctly. Previously, that was only done when the session info changed to "FETCHED" from any other state (or when the project ID changes). This change also fetches project info when the session info when the session status is already "FETCHED" before the <Preview> component is mounted.
cwillisf
commented
Oct 22, 2025
Comment on lines
-286
to
-287
| />} | ||
| {banner} |
There was a problem hiding this comment.
Note that the } in this />} is associated with the showEmailConfirmationBanner check, so {banner} is not affected by that conditional. IMO, the indentation makes that look confusing in the diff when "Hide whitespace" is enabled. :/
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves:
Changes:
This appears to be a general timing issue. I'm not sure why it shows up as a problem on mobile Safari specifically.
Basically, we need to fetch project info in order for the project page to load correctly. Previously, that was only done when the session info changed to "FETCHED" from any other state (or when the project ID changes). This change also fetches project info when the session info when the session status is already "FETCHED" before the component is mounted.
In addition, I added a spinner that displays on the project page if the main content components don't load. That spinner should never appear for very long, but if it does, its
classNameshould provide a hint for whoever tries to debug the problem in the future. As part of this, I converted severala && <b />constructs toif (a) { children.push(b) }, which changed indentation, so I recommend viewing the diff with "Hide whitespace" enabled.Here's a screenshot of the spinner in action: