Fix: Hide info icon in idle state (resolves #497)

[sahiljagtap08]

Contributor checklist

• This pull request is on a separate branch and not the main branch
• I have tested my code with the ./gradlew lintKotlin detekt test command as directed in the testing section of the contributing guide

---

Description

The information icon was appearing in both idle state (command selection) and invalid state (after invalid input). This fix ensures the icon only appears when there's actually an invalid input error, not during normal command browsing.

Changes:

• Added binding.ivInfo.visibility = View.GONE in setupIdleView()

• Icon now only shows in setupInvalidView() as intended

  The Problem:

  • Icon was showing when users clicked the Scribe key and selected a command (confusing for new users)
  • Icon was correctly showing for invalid input (this behavior is kept)

  The Solution:
  Added binding.ivInfo.visibility = View.GONE in three locations:

  • setupIdleView() - hides icon in normal typing state
  • setupSelectCommandView() - hides icon when viewing command menu
  • setupToolbarView() - hides icon when a command is selected

  The icon now only shows in setupInvalidView() when there's actually invalid input.

  Testing:

  • Tested that icon doesn't appear when selecting commands from menu
  • Tested that icon properly appears when entering invalid text like "asdfghjkl;"
  • Verified icon click functionality still works in invalid state

  Related issue

  • Invalid state icon should only be shown on command bar after an invalid input #497

[github-actions]

Thank you for the pull request! ❤️

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest that you use the Element client as well as Element X for a mobile app, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

[github-actions]

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

• The linting, formatting and testing workflows within the PR checks do not indicate new errors in the files changed

  • Tests may need to be reran as they're at times not deterministic

• The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

[github-actions]

First PR Commit Check

• The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
  - The contributor's name and icon in remote commits should be the same as what appears in the PR
  - If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Android repo (can be set with git config --global user.email "GITHUB_EMAIL")

[andrewtavis]

Hey @sahiljagtap08 👋 In checking the commit message for this PR, it looks like your email for GitHub isn't set up properly. Can you make sure that the email you use for GitHub matches what you have for git config user.email in your local Scribe-Android repo (can be set with git config --global user.email "GITHUB_EMAIL"). As it stands, you wouldn't get a contribution to your account for this PR 😊 Could you fix your email, send a commit to this with a random change, and then send another commit to remove the change? I can then squash the changes and your account will get the commit.

If it's not important to you, then we can also proceed with the review! :)

[sahiljagtap08]

Hi @andrewtavis ! I've corrected my git config to use [email protected] (which is my verified GitHub email). Ready for review whenever you are!

[andrewtavis]

praise: All's working really well here, @sahiljagtap08 😊 Thanks so much for your contribution!