Toastr sound #978
Open
Toastr sound #978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csachdeva83
commented
Feb 25, 2023
csachdeva83
commented
- Issue: Add sound to notification #973
- Feature
- enableSound option in Individual Options
- Sound will be as per toastr type
* Install howler package * Add error.mp3 and success.mp3 files
* Enable & Disable Sound option add in home html * Add enableSound key in interface IndividualConfig * Default enableSound is false
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #978 +/- ##
==========================================
+ Coverage 55.11% 55.49% +0.37%
==========================================
Files 19 19
Lines 508 510 +2
Branches 88 89 +1
==========================================
+ Hits 280 283 +3
- Misses 216 217 +1
+ Partials 12 10 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@scttcper Please review this PR and list out any changes you desire. |
|
its interesting, but i don't think it belongs as part of the toastr |
Why so ? |
maniya81
reviewed
Sep 27, 2025
| tapToDismiss: true, | ||
| onActivateTick: false, | ||
| progressAnimation: 'decreasing', | ||
| enableSound: false, |
There was a problem hiding this comment.
Greaty PR, Hope it get's merged and we get to see this feature soon
maniya81
reviewed
Sep 27, 2025
| src: ['assets/notification-sound/success.mp3'], | ||
| })], | ||
| ['error', new Howl({ | ||
| src: ['assets/notification-sound/error.mp3'], |
There was a problem hiding this comment.
Consider keeping asset paths in a config file or environment variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.