PRINCE: Fix deprecated construct in po-parse script #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `keys $var` form was removed in Perl 5.24. Replaced with the correct
`keys %{$var}` form.
This script used to reference a submodule in the ScummVM source tree with the translation sources. That submodule was removed, so the script now expects an argument and prints a hint if the directory does not exist: ``` % ./engines/prince/gen-translations.sh Usage: ./engines/prince/gen-translations.sh <path-to-scummvm-game-translations> Download or clone from https://github.com/scummvm/game-translations/tree/prince-and-the-coward ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a syntax error in newer Perls and modifies gen-translations.sh to expect an explicit path to the game translation directory.