Skip to content

Fixes empty filter bug from ibis breaking changes #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixes empty filter bug from ibis breaking changes #79

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7afa356
fix empty filter bug
pablo-gar Nov 28, 2024
245cd1c
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/genomic_features/ensembl/ensembldb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,12 @@ def _build_query(
else:
query = self.db.table(table)
# add filter
query = query.filter(filter.convert()).select(cols).order_by(cols)

filter = filter.convert()
if filter is not None:
query = query.filter(filter)

query = query.select(cols).order_by(cols)
return query

def _join_query(
Expand Down
Loading