Skip to content

Conversation

meeseeksmachine
Copy link
Contributor

Backport PR #3543: Fix in non multiGPU training to have history saved in memory, and not on disk by default

…y saved in memory, and not on disk by default
@lumberbot-app lumberbot-app bot added cuda tests Run test suite on CUDA on-merge: backport to 1.4.x on-merge: backport to 1.4.x labels Sep 28, 2025
@meeseeksmachine meeseeksmachine added cuda tests Run test suite on CUDA on-merge: backport to 1.4.x on-merge: backport to 1.4.x labels Sep 28, 2025
Copy link

codecov bot commented Sep 28, 2025

Codecov Report

❌ Patch coverage is 42.10526% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.87%. Comparing base (5745041) to head (49d2fc8).
⚠️ Report is 1 commits behind head on 1.4.x.

Files with missing lines Patch % Lines
src/scvi/train/_logger.py 25.00% 9 Missing ⚠️
src/scvi/external/mrvi_jax/_model.py 75.00% 1 Missing ⚠️
src/scvi/train/_trainer.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            1.4.x    #3544   +/-   ##
=======================================
  Coverage   77.86%   77.87%           
=======================================
  Files         224      224           
  Lines       20986    20992    +6     
=======================================
+ Hits        16341    16347    +6     
  Misses       4645     4645           
Files with missing lines Coverage Δ
src/scvi/external/mrvi_jax/_model.py 61.56% <75.00%> (ø)
src/scvi/train/_trainer.py 86.20% <66.66%> (-1.30%) ⬇️
src/scvi/train/_logger.py 83.11% <25.00%> (-8.67%) ⬇️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ori-kron-wis ori-kron-wis merged commit 67d181d into scverse:1.4.x Sep 29, 2025
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda tests Run test suite on CUDA on-merge: backport to 1.4.x on-merge: backport to 1.4.x

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants