Skip to content

Add GLOBE_ICON_FN to main.rc #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 26, 2025
Merged

Add GLOBE_ICON_FN to main.rc #571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
67ef467
Add GLOBE_ICON_FN to main.rc
sdatkinson May 25, 2025
8c80929
Update pull_request_template.md
sdatkinson May 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,5 @@ Include [Closing words](https://docs.github.com/en/issues/tracking-your-work-wit
- [ ] Does your PR add, remove, or rename any plugin parameters? If yes...
- [ ] Have you ensured that the plug-in unserializes correctly?
- [ ] Have you ensured that _older_ versions of the plug-in load correctly? (See [`Unserialization.cpp`](https://github.com/sdatkinson/NeuralAmpModelerPlugin/blob/main/NeuralAmpModeler/Unserialization.cpp).)
- [ ] Does your PR add or remove any graphical assets? If yes, are they defined in [config.h](https://github.com/olilarkin/NeuralAmpModelerPlugin/blob/main/NeuralAmpModeler/config.h) and added in the two required locations in [main.rc](https://github.com/olilarkin/NeuralAmpModelerPlugin/blob/main/NeuralAmpModeler/resources/main.rc)?

2 changes: 2 additions & 0 deletions NeuralAmpModeler/resources/main.rc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,7 @@ BEGIN
"MICHROMA_FN TTF MICHROMA_FN\r\n"
"FILE_FN SVG FILE_FN\r\n"
"GEAR_FN SVG GEAR_FN\r\n"
"GLOBE_ICON_FN SVG GLOBE_ICON_FN\r\n"
"CLOSE_BUTTON_FN SVG CLOSE_BUTTON_FN\r\n"
"LEFT_ARROW_FN SVG LEFT_ARROW_FN\r\n"
"RIGHT_ARROW_FN SVG RIGHT_ARROW_FN\r\n"
Expand Down Expand Up @@ -263,6 +264,7 @@ ROBOTO_FN TTF ROBOTO_FN
MICHROMA_FN TTF MICHROMA_FN
FILE_FN SVG FILE_FN
GEAR_FN SVG GEAR_FN
GLOBE_ICON_FN SVG GLOBE_ICON_FN
CLOSE_BUTTON_FN SVG CLOSE_BUTTON_FN
LEFT_ARROW_FN SVG LEFT_ARROW_FN
RIGHT_ARROW_FN SVG RIGHT_ARROW_FN
Expand Down
Loading