Skip to content

Refactor git submodules out of NeuralAmpModeler directory #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 17, 2025
Merged

Refactor git submodules out of NeuralAmpModeler directory #581

merged 5 commits into from
Jul 17, 2025

Conversation

@sdatkinson
Copy link
Owner

@sdatkinson sdatkinson commented Jul 17, 2025 •
edited
Loading

Description

Resolves #580

PR Checklist

  • Did you format your code using format.bash?
  • Does the VST3 plugin pass all of the unit tests in the VST3PluginTestHost? (Download it as part of the VST3 SDK here.)
    • Windows
    • macOS
  • [N] Does your PR add, remove, or rename any plugin parameters? If yes...
    • [N/A] Have you ensured that the plug-in unserializes correctly?
    • [N/A] Have you ensured that older versions of the plug-in load correctly? (See Unserialization.cpp.)
  • [N] Does your PR add or remove any graphical assets? If yes, are they defined in config.h and added in the two required locations in main.rc?

@sdatkinson sdatkinson marked this pull request as ready for review July 17, 2025 20:58
@sdatkinson sdatkinson merged commit da2339d into main Jul 17, 2025
2 checks passed
@sdatkinson sdatkinson deleted the 580-submodules branch July 17, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor submodules out of NeuralAmpModeler

2 participants

@sdatkinson