Remove futures-03-sink feature flag for ByteWriter
#162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdroege
reviewed
Jul 1, 2025
sdroege
reviewed
Jul 1, 2025
|
What's the status here? |
I answered all questions in the reviews. They are marked as "Pending" now |
nanoqsh
commented
Jul 16, 2025
It looks like you forgot to actually submit them two weeks ago (but now they're there). Now we both waited for each other, I guess :) |
sdroege
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #155
As proposed, a sealed trait
Senderwas added:futures-03-sinkfeature is enabled, it's an alias forSink<Message, Error = WsError>futures-03-sinkfeature is disabled, it's implemented only forWebSocketStreamandWebSocketSender