Allow ReferentialIntegrity metric to work on composite keys#859
Conversation
sarahmish
left a comment
There was a problem hiding this comment.
Maybe add a test for compute_breakdown with composite keys that have null values? This should include when the entire both keys are null and one only a single key is null in the composite key
| how='left', | ||
| left_on=fk_columns, | ||
| right_on=pk_columns, | ||
| indicator=INDICATOR_NAME, |
There was a problem hiding this comment.
what if INDICATOR_NAME is part of existing columns? Maybe you can create a temporary indicator using _create_unique_name?
indicator = _create_unique_name(
INDICATOR_NAME, pk_columns + fk_columns
)There was a problem hiding this comment.
@pvk-developer I was referring to an already existing function in sdv._utils, similar to how it's being used here.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/composite-keys #859 +/- ##
==========================================================
+ Coverage 95.72% 95.73% +0.01%
==========================================================
Files 117 117
Lines 4914 4927 +13
==========================================================
+ Hits 4704 4717 +13
Misses 210 210
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ReferentialIntegrity metric to work on composite keys
sarahmish
left a comment
There was a problem hiding this comment.
Left one comment to make the condition easier to read, but this is ready for merge
Resolves #838
CU-86b8atdg7