Make reports compatible with composite keys#862
Make reports compatible with composite keys#862frances-h merged 3 commits intofeature/composite-keysfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/composite-keys #862 +/- ##
==========================================================
- Coverage 95.74% 95.74% -0.01%
==========================================================
Files 117 117
Lines 4934 4955 +21
==========================================================
+ Hits 4724 4744 +20
- Misses 210 211 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sarahmish
left a comment
There was a problem hiding this comment.
Looks good to me, I just wonder about the one comment in terms of error description.
| combined_index = contingency_real.index.union(contingency_synthetic.index, sort=False) | ||
| combined_index = contingency_real.index.union( | ||
| contingency_synthetic.index, sort=False | ||
| ).drop_duplicates() |
There was a problem hiding this comment.
Fixes a test error on minimum versions: union on older versions of pandas doesn't treat NaNs as a single value so if a column has a null category, duplicate indices get created. Adding the drop_duplicates call removes the duplicated indices.
Resolve #835