Skip to content

Make reports compatible with composite keys#862

Merged
frances-h merged 3 commits intofeature/composite-keysfrom
issue-835-reports-composite-keys
Mar 5, 2026
Merged

Make reports compatible with composite keys#862
frances-h merged 3 commits intofeature/composite-keysfrom
issue-835-reports-composite-keys

Conversation

@frances-h
Copy link
Copy Markdown
Contributor

Resolve #835

@frances-h frances-h self-assigned this Mar 5, 2026
@frances-h frances-h requested a review from a team as a code owner March 5, 2026 15:46
@frances-h frances-h requested review from pvk-developer and sarahmish and removed request for a team March 5, 2026 15:46
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 5, 2026

Codecov Report

❌ Patch coverage is 97.43590% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.74%. Comparing base (cec3fa4) to head (3085bc5).
⚠️ Report is 1 commits behind head on feature/composite-keys.

Files with missing lines Patch % Lines
.../reports/single_table/_properties/data_validity.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                     @@
##           feature/composite-keys     #862      +/-   ##
==========================================================
- Coverage                   95.74%   95.74%   -0.01%     
==========================================================
  Files                         117      117              
  Lines                        4934     4955      +21     
==========================================================
+ Hits                         4724     4744      +20     
- Misses                        210      211       +1     
Flag Coverage Δ
integration 81.21% <92.30%> (+0.34%) ⬆️
unit 84.46% <89.74%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@sarahmish sarahmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, I just wonder about the one comment in terms of error description.

combined_index = contingency_real.index.union(contingency_synthetic.index, sort=False)
combined_index = contingency_real.index.union(
contingency_synthetic.index, sort=False
).drop_duplicates()
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes a test error on minimum versions: union on older versions of pandas doesn't treat NaNs as a single value so if a column has a null category, duplicate indices get created. Adding the drop_duplicates call removes the duplicated indices.

Copy link
Copy Markdown
Member

@pvk-developer pvk-developer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@frances-h frances-h merged commit c1f747c into feature/composite-keys Mar 5, 2026
57 checks passed
@frances-h frances-h deleted the issue-835-reports-composite-keys branch March 5, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants