Dungeon Quest Update to set obj.needDungeonQuest to nil if the player has completed the dungeon quest.#12
Open
token419 wants to merge 1 commit intosecretrob:mainfrom
Open
Dungeon Quest Update to set obj.needDungeonQuest to nil if the player has completed the dungeon quest.#12token419 wants to merge 1 commit intosecretrob:mainfrom
token419 wants to merge 1 commit intosecretrob:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sets obj.needDungeonQuest to nil if the player has completed the dungeon quest.
Previously it was only being set to true if the player had not completed the quest, but then would never get set to false unless the UI got reloaded, so if the player subsequently used the feature to select all the quests on the next run, it would have also included any they had completed in this play session as well.