Updates Tamiflex to work with the modern JDK and ASM.#8
Open
jtoman wants to merge 2 commits intosecure-software-engineering:masterfrom
Open
Updates Tamiflex to work with the modern JDK and ASM.#8jtoman wants to merge 2 commits intosecure-software-engineering:masterfrom
jtoman wants to merge 2 commits intosecure-software-engineering:masterfrom
Conversation
jtoman
commented
Aug 20, 2018
- Adds EXPAND_FRAMES argument to visit() in the class renamer, without which ASM dies
- Adds constant whitelist, which we use to ignore the "$Proxy" constant loaded in the ProxyFactory. Usually whenever TamiFlex sees a constant with one of the "generated name" tokens, it assumes it is a reference to a generated class name, but the use of "$Proxy" breaks this assumption. The "isWhitelistConstant" method can be extended to handle other such scenarios as necessary.
- Treats _pyx classes as generated, as per python.6.x6.nabble.com/Is-the-org-python-pycode-package-generated-code-td1782284.htmlL
Also adds expand_frames without which the renaming fails
They are actually generated at runtime
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.