-
Notifications
You must be signed in to change notification settings - Fork 9
feat(CSAF2.1): #287 add mandatory test 6.1.26 #380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
) { | ||
ctx.isValid = false | ||
ctx.errors.push({ | ||
instancePath: `/document/category`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency reasons, maybe better using single quotes '
'
?
if (category.toLowerCase().startsWith('csaf_')) { | ||
ctx.isValid = false | ||
ctx.errors.push({ | ||
instancePath: `/document/category`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency reasons, maybe better using single quotes '
'
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please see my comments in the code
d1e13a5
to
01a1dd2
Compare
Coverage after merging feat/287-csaf-2.1-mandatory-test-6.1.26 into main
Coverage Report
|
Coverage after merging feat/287-csaf-2.1-mandatory-test-6.1.26 into main
Coverage Report
|
Coverage after merging feat/287-csaf-2.1-mandatory-test-6.1.26 into main
Coverage Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comments
07453b5
to
a933940
Compare
Coverage after merging feat/287-csaf-2.1-mandatory-test-6.1.26 into main
Coverage Report
|
No description provided.