kernel update: Api remove genesis and change tip methods #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…354d1ce5c47 b354d1ce5c47 Merge bitcoin/bitcoin#33820: kernel: trim Chain interface a4e96cae7d3d Merge bitcoin/bitcoin#33042: refactor: inline constant return values from `dbwrapper` write methods 8c2710b0415f Merge bitcoin/bitcoin#32517: rpc: add "ischange: true" to decoded tx outputs in wallet gettransaction response 1fe851a4781a Merge bitcoin/bitcoin#32180: p2p: Advance pindexLastCommonBlock early after connecting blocks 5f0303b93fa7 Merge bitcoin/bitcoin#33443: log: reduce excessive "rolling back/forward" messages during block replay f4903dddc9ea Merge bitcoin/bitcoin#33433: Bugfix: QA: rpc_bind: Skip nonloopback test if no such address is found 06e9458869ee Merge bitcoin/bitcoin#32856: Update `minisketch` subtree 66978a1a9537 kernel: remove btck_chain_get_tip 4dd7e6dc48ed kernel: remove btck_chain_get_genesis 490cb056f651 Merge bitcoin/bitcoin#33785: util: Allow `Assert` (et al.) in contexts without __func__ dcd0099a765e Merge bitcoin/bitcoin#33826: scripted-diff: Remove obsolete comment 01adbbcd9c50 Merge bitcoin/bitcoin#33827: doc: Correct `pkgin` command usage on NetBSD eec21bc7c8bf Merge bitcoin/bitcoin#33536: doc: reference fuzz coverage steps in quick-start 035f934e02f9 Merge bitcoin/bitcoin#33823: ci: Use cmake --preset=dev-mode in test-each-commit task ddd2afac1073 Merge bitcoin/bitcoin#33676: interfaces: enable cancelling running `waitNext` calls dee7eec64389 doc: mention coverage build in quickstart section 0698c6b494de doc: Correct `pkgin` command usage on NetBSD 36724205fc1f scripted-diff: Remove obsolete comment ca1ce52a0f1e Merge bitcoin/bitcoin#33825: refactor: Add missing include in bitcoinkernel_wrapper.h fa1e8d8bad92 refactor: Add missing include in bitcoinkernel_wrapper.h fa6db67369fb ci: [refactor] Extract build_dir constant in ci-test-each-commit-exec.py fa95e6cdc1c5 ci: Use cmake --preset=dev-mode in test-each-commit task 513a0da2e0c8 Merge bitcoin/bitcoin#33818: ci: Extend tidy job to cover kernel code 5d0a40d607d4 ci: Extend tidy job to cover kernel code 93e79181da8c Merge bitcoin/bitcoin#33786: script: remove dead code in `CountWitnessSigOps` 3c4bec62239d Merge bitcoin/bitcoin#33782: test: remove obsolete `get_{key,multisig}` helpers from wallet_util.py 4b12beedaef5 Merge bitcoin/bitcoin#33793: test: move create_malleated_version() to messages.py for reuse 0b45e6db1058 Merge bitcoin/bitcoin#33789: doc: add cmake help option in Windows build docs 2b9c3511986b Merge bitcoin/bitcoin#33768: refactor: remove dead branches in `SingletonClusterImpl` fad6efd3bef1 refactor: Use STR_INTERNAL_BUG macro where possible fada379589a1 doc: Remove unused bugprone-lambda-function-name suppression 2bd155e6ee7e test: move create_malleated_version() to messages.py for reuse 9577daa3b88a doc: Add cmake help option in Windows build instructions fae1d99651e2 refactor: Use const reference to std::source_location fa5fbcd61563 util: Allow Assert() in contexts without __func__ 24bcad3d4df5 refactor: remove dead code in `CountWitnessSigOps` ec8516ceb756 test: remove obsolete `get_{key,multisig}` helpers from wallet_util.py 2d23820ee116 refactor: remove dead branches in `SingletonClusterImpl` 060bb5550824 rpc: add decoded tx details to gettransaction with extra wallet fields ad1c3bdba547 [move only] move DecodeTxDoc() to a common util file for sharing d633db541664 rpc: add "ischange: true" in wallet gettransaction decoded tx output dcb56fd4cb59 interfaces: add interruptWait method c235aa468b0d Update minisketch subtree to latest upstream 4543a3bde26f Squashed 'src/minisketch/' changes from ea8f66b1ea..d1bd01e189 01cc20f3307c test: improve coverage for a resolved stalling situation 9af6daf07ed0 test: remove magic number when checking for blocks that have arrived 3069d66dcac0 p2p: During block download, adjust pindexLastCommonBlock better 1fc7a81f1f5f log: reduce excessive messages during block replay 79b4c276e7b9 Bugfix: QA: rpc_bind: Skip nonloopback test if no such address is found 743abbcbde9e refactor: inline constant return value of `BlockTreeDB::WriteBatchSync` and `BlockManager::WriteBlockIndexDB` and `BlockTreeDB::WriteFlag` e030240e9094 refactor: inline constant return value of `CDBWrapper::Erase` and `BlockTreeDB::WriteReindexing` cdab9480e9e3 refactor: inline constant return value of `CDBWrapper::Write` d1847cf5b5af refactor: inline constant return value of `TxIndex::DB::WriteTxs` 50b63a5698e5 refactor: inline constant return value of `CDBWrapper::WriteBatch` git-subtree-dir: libbitcoinkernel-sys/bitcoin git-subtree-split: b354d1ce5c47997aa2f93910e05c0f8daa8736eb
Owner
Author
|
Would be interested in hearing your opinion here @alexanderwiederin. I think I prefer the simpler interface here over genesis and tip convenience methods, but I am also not fully sold. |
Contributor
|
I think |
Owner
Author
I think that would actually be desirable. Or do you see a concern here? |
Contributor
From the iterator docs: https://doc.rust-lang.org/std/iter/trait.Iterator.html#method.last |
Owner
Author
|
Mmh, that is interesting, might just keep the tip() then. |
Contributor
Makes sense. Agree that |
sedited
force-pushed
the
api_remove_genesis_tip
branch
from
6c9526a to
492c64c
Compare
sedited
changed the title
Owner
Author
|
Pushed to leave the tip() in place. |
Contributor
|
Small nit to clarify in commit message |
sedited
force-pushed
the
api_remove_genesis_tip
branch
from
492c64c to
63b2788
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.