Skip to content

Refactor Queue Handling in segment_destination.dart #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Refactor Queue Handling in segment_destination.dart #162

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
713a312
LIBRARIES-2612 - Refactor Dequeue Handling Operation
neelkanth-kaushik May 23, 2025
05dde32
LIBRARIES-2612 - Refactor Dequeue Handling Operation
neelkanth-kaushik May 23, 2025
78bfc96
LIBRARIES-2612 - Refactor Dequeue Handling Operation
neelkanth-kaushik May 23, 2025
8b31680
Refactor Dequeue Handling Operation
neelkanth-kaushik May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions packages/core/lib/plugins/segment_destination.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,24 +30,25 @@ class SegmentDestination extends DestinationPlugin with Flushable {
final List<RawEvent> sentEvents = [];
var numFailedEvents = 0;

// Iterate over each batch in chunkedEvents sequentially
await Future.forEach(chunkedEvents, (batch) async {
try {
final succeeded = await analytics?.httpClient.startBatchUpload(
analytics!.state.configuration.state.writeKey, batch,
host: _apiHost);
if (succeeded == null || !succeeded) {
if (succeeded == true) { // If the upload succeeded, all events in the batch are added to sentEvents.
sentEvents.addAll(batch);
} else { // If it failed, increase the numFailedEvents counter by the number of events in the failed batch.
numFailedEvents += batch.length;
}
sentEvents.addAll(batch);
} catch (e) {
numFailedEvents += batch.length;
} finally {
_queuePlugin.dequeue(sentEvents);
}
});

if (sentEvents.isNotEmpty) {
log("Sent ${sentEvents.length} events", kind: LogFilterKind.debug);
_queuePlugin.dequeue(sentEvents); // Removed events that were successfully sent from the internal queue
log("Successfully Sent ${sentEvents.length} events", kind: LogFilterKind.debug);
}

if (numFailedEvents > 0) {
Expand Down