This repository was archived by the owner on Apr 13, 2023. It is now read-only.
Fix 404 when performing task lookup#57
Open
mikesir87 wants to merge 2 commits intosegmentio:masterfrom
Open
Conversation
|
The cood looks good to me! Are you sure this won’t introduce regressions? |
Contributor
Author
|
I did wonder if there might be regressions, but tracing through the codebase, it looks like...
So... it looks like the changes are safe at this point since nothing else is using these various code paths. |
|
@stephenmathieson is this repo still maintained? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #51
The UI is sending the service name (see below). This updates the API to treat it as the service name, rather than the task family name.
specs/client/containers/clusters/index.js
Lines 197 to 198 in ea078d9