Skip to content

[SEGDP-2781] Migrate AWS Go SDK to V2 #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Sep 23, 2025
Merged

[SEGDP-2781] Migrate AWS Go SDK to V2 #241

merged 15 commits into from
Sep 23, 2025

Conversation

@pazhang-25
Copy link
Contributor

@pazhang-25 pazhang-25 commented Sep 19, 2025 •
edited
Loading

What was done

  • This ticket migrates the AWS Go SDK used in topicctl from v1 -> v2. v1 has been deprecated since July 2025. Below are some of the major changes:
    • Go SDK V2 no longer supports the session module, so there are many places where the session module has been replaced with github.com/aws/aws-sdk-go-v2/aws.Config instead.
      • The NewAdminClient under cluster.go has been updated to take a Config parameter instead of a session
      • The getAdminClient function in shared.go has been updated to take a Config parameter instead of a session
    • Upgraded github.com/segmentio/kafka-go to v0.4.49
    • Started to use github.com/segmentio/kafka-go/sasl/aws_msk_iam_v2 instead of v1
    • Updated connector.go to use the aws-sdk-go-v2 signer and also to use aws_msk_iam_v2 in kafka-go.
    • Upgraded to V2 for EC2 service in zkclient.go
  • Details of testing are in JIRA ticket

@pazhang-25 pazhang-25 changed the title migrating delete.go and all cascading files [SEGDP-2781] Migrate AWS Go SDK to V2 Sep 19, 2025
@pazhang-25 pazhang-25 marked this pull request as ready for review September 22, 2025 14:01
@pazhang-25 pazhang-25 requested a review from a team as a code owner September 22, 2025 14:01
@pazhang-25 pazhang-25 marked this pull request as draft September 22, 2025 14:07
@pazhang-25 pazhang-25 marked this pull request as ready for review September 22, 2025 19:20
petedannemann
petedannemann reviewed Sep 22, 2025
View reviewed changes
Copy link
Contributor

@petedannemann petedannemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, left a few comments

@pazhang-25 pazhang-25 merged commit 83e63fd into master Sep 23, 2025
13 checks passed
@pazhang-25 pazhang-25 deleted the SEGDP-2781/updateAwsSDKGo branch September 23, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petedannemann petedannemann petedannemann approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pazhang-25 @petedannemann