Draft
Conversation
qlrd
force-pushed
the
docs/contrib-guidelines
branch
from
5955e70 to
ef98a0d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #816 +/- ##
========================================
Coverage 97.31% 97.31%
========================================
Files 83 83
Lines 10614 10614
========================================
Hits 10329 10329
Misses 285 285 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
qlrd
force-pushed
the
docs/contrib-guidelines
branch
5 times, most recently
from
b5e9334 to
1137f7d
Compare
qlrd
force-pushed
the
docs/contrib-guidelines
branch
2 times, most recently
from
3cf9dd5 to
71f346a
Compare
odudex
requested changes
Mar 19, 2026
qlrd
force-pushed
the
docs/contrib-guidelines
branch
2 times, most recently
from
c9202cf to
902a07d
Compare
qlrd
force-pushed
the
docs/contrib-guidelines
branch
5 times, most recently
from
60423df to
0b07342
Compare
qlrd
force-pushed
the
docs/contrib-guidelines
branch
from
0b07342 to
f4a2cec
Compare
qlrd
force-pushed
the
docs/contrib-guidelines
branch
from
f4a2cec to
67cf800
Compare
odudex
reviewed
Apr 15, 2026
| - style: formatting, missing semi colons, etc; no code change; | ||
| - test: adding missing tests or correcting existing tests. | ||
|
|
||
| It is strongly encouraged that you |
Member
Author
There was a problem hiding this comment.
TY, forgot about that one. I changed a code a little, do not know if i put a TL;DR about. IMO, commits should have the same "verify" behaviour that we have when sign asset releases.
Member
There was a problem hiding this comment.
IMO code speaks for itself, and doesn't require a signature (who made it shouldn't be an evaluation criteria)
qlrd
force-pushed
the
docs/contrib-guidelines
branch
3 times, most recently
from
2598edd to
b0584cb
Compare
`CONTRIBUTING.md` is a important file that guides new developers through the standards built by krux team through years. This isn't a monad and could be changed at time to time.
qlrd
force-pushed
the
docs/contrib-guidelines
branch
from
b0584cb to
7fd1f55
Compare
odudex
reviewed
Apr 16, 2026
| All files should have the MIT license with updated years from when we stated | ||
| the project (2021) until today (2026 when writing this document). | ||
|
|
||
| #### New features |
Member
There was a problem hiding this comment.
IMO this section's requirements are not coherent with our code
odudex
reviewed
Apr 16, 2026
| return bar_str + baz_str | ||
| ``` | ||
|
|
||
| ### Markdown |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
CONTRIBUTING.mdis a important file that guides new developers through the standards built by krux team through years. This isn't a monad and could be changed at time to time.Changes made to:
Did you build the code and tested on device?
What is the purpose of this pull request?