Added FromStr impls for enums that have Display trait #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arsable, improving completeness.
Contributor
|
Hm I didn't realize that Display had been implemented, I would have raised objections to that as I don't think that is really within the purview of this crate. Mainly because internationalization is very relevant within this sort of crate. I think Debug is great, but Display is a bit weird since the enums shouldn't really be used directly for formatting, and internationalization is extremely relevant for this sort of API, and all this shows is English. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many enums in the crate provide the
Displaytrait, while very few provideFromStr.The
FlowControlenum for example has been provided with both traits, whileDataBits,StopBitsandPartityenums feature only theDisplaytrait.Added
FromStrimlementation to these three enums to improve completeness and assist in applications that require converting from a string in the UI into these enum values.