Skip to content

Conversation

Bo98
Copy link

@Bo98 Bo98 commented Dec 17, 2023

One of the scenarios where turbo_tests doesn't work as a drop-in replacement for parallel_tests yet is that the latter reads from .rspec_parallel, if available. An important difference .rspec_parallel has over .rspec is that it overrides any global ~/.rspec config.

https://github.com/grosser/parallel_tests/blob/6e9be6f529b64e5f9c8e4439754bca0b2ef3f2b1/lib/parallel_tests/rspec/runner.rb#L80

@ilyazub ilyazub self-requested a review January 17, 2024 16:21
Copy link
Collaborator

@ilyazub ilyazub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Bo98! Apologies for not reviewing your PRs sooner.

Let's use ParallelTests::RSpec::Runner.send(:spec_opts) directly. We are fine with depending on parallel-tests and will probably use it's API even more (ref: #41)

[]
end

spec_opts = ["-O", options_file] if options_file
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use parallel-tests directly.

Suggested change
spec_opts = ["-O", options_file] if options_file
spec_opts = ParallelTests::RSpec::Runner.send(:spec_opts)

@tkling
Copy link

tkling commented Jan 23, 2024

I just happened to be looking for this support, +1 for the PR @Bo98! Thanks for adding this ❤️ 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants