fix - change the way the log level is mapped#22
Merged
DanielMuller merged 1 commit intoserverless-guru:mainfrom Mar 21, 2025
Merged
fix - change the way the log level is mapped#22DanielMuller merged 1 commit intoserverless-guru:mainfrom
DanielMuller merged 1 commit intoserverless-guru:mainfrom
Conversation
DanielMuller
approved these changes
Mar 21, 2025
ljsomm
force-pushed
the
bugfix/log-level-zero-mapping
branch
from
cd2d6c2 to
bf59600
Compare
bboure
approved these changes
Mar 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problematic case:
Whenever we try to map debug level to it's equivalent number representation (0) and check if it was corrected map by using pipes (
||) we might receive an undesired behavior:Given that, a good alternative is to use nullable coalescing operator (
??), so in this scenario the problem won't happen: