Skip to content

Remove XmlState::Quiescent #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2025
Merged

Remove XmlState::Quiescent #668

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions xml5ever/src/tokenizer/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -667,10 +667,6 @@ impl<Sink: TokenSink> XmlTokenizer<Sink> {

debug!("processing in state {:?}", self.state);
match self.state.get() {
XmlState::Quiescent => {
self.state.set(XmlState::Data);
ProcessResult::Done
},
//§ data-state
XmlState::Data => loop {
match pop_except_from!(self, input, small_char_set!('\r' '&' '<')) {
Expand Down Expand Up @@ -1163,7 +1159,7 @@ impl<Sink: TokenSink> XmlTokenizer<Sink> {
fn eof_step(&self) -> ProcessResult<Sink::Handle> {
debug!("processing EOF in state {:?}", self.state.get());
match self.state.get() {
XmlState::Data | XmlState::Quiescent => go!(self: eof),
XmlState::Data => go!(self: eof),
XmlState::CommentStart | XmlState::CommentLessThan | XmlState::CommentLessThanBang => {
go!(self: reconsume Comment)
},
Expand Down
4 changes: 0 additions & 4 deletions xml5ever/src/tokenizer/states.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,10 +153,6 @@ pub enum XmlState {
/// Indicates that the parser is currently parsing an ill-formed comment, such as
/// `<? this is not what a comment should look like! >`.
BogusComment,
/// Interrupts the tokenizer for one single call to `step`.
///
/// It is unclear whether this is still necessary ([#649](https://github.com/servo/html5ever/issues/649)).
Quiescent,
}

/// Specifies how an attribute value is quoted, if at all.
Expand Down