Conversation
|
I hoped to get it work with the version-aware resolver, but that doesn't work, the config key is ignored for some reason. Going to fix it the other way. (We can't globally enable it since we test on MSRV 1.63 which doesn't have the resolver) |
|
@hsivonen looks like this fails IdnaTest with latest ICU4X https://github.com/servo/rust-url/actions/runs/18976174234/job/54196290241?pr=1085 Seems to be resolved by updating IdnaTestV2 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1085 +/- ##
=======================================
Coverage ? 82.25%
=======================================
Files ? 24
Lines ? 4220
Branches ? 0
=======================================
Hits ? 3471
Misses ? 749
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Why are all of the CI tasks immediately getting canceled when one fails? It's making it hard to fix these CI errors since a different one fails with a new one each time: i can never tell if what I am trying is working.
|
a3a35d1 to
a91225c
Compare
* Attempt to fix 1.82 CI * Update idna tests * syn
ICU4X 2.1 has MSRV 1.83