Replace stylo_atoms crate with StyleAtom type from the web_atoms crate
#239
Conversation
Any ancestors of this commit are from upstream mozilla-central, with some filtering and renaming. Our patches and sync tooling start here. The sync tooling has all been squashed into this commit, based on: https://github.com/servo/stylo/commits/64731e10dc8ef87ef52aa2fb9f988c3b2530f3a7
This is a rebase of 35cd802, but with 6a39161 reverted. Signed-off-by: Oriol Brufau <[email protected]>
Signed-off-by: Oriol Brufau <[email protected]>
Signed-off-by: Oriol Brufau <[email protected]>
Signed-off-by: Oriol Brufau <[email protected]>
Signed-off-by: Nico Burns <[email protected]>
Signed-off-by: Nico Burns <[email protected]>
Why is this a problem? |
It's kind of annoying when trying to view "the diff", as it's extra code that will always be there. However, part of my motivation is also that I would like to merge all of the atom types into one: I don't think there's much benefit to them being separate (gecko has them combined - and we could still wrap them in newtypes if we want type safety), and there are a few places I've run into where I've had to convert between atom types which would be much cheaper if they were all one underlying type. |
|
My concern is that I frequently need to add new atoms when upgrading Stylo. If I need to add them into the other repo, wait for a web_atoms release and yada yada, it's not much convenient. |
Move the
stylo_atoms::Atomtype toweb_atoms::StyleAtomin thehtml5everrepo and then delete thestylo_atomscrate so that we don't have to maintain it in this repo where it must be frequently rebased on top of upstream.Depends on:
StyleAtomtoweb_atomshtml5ever#661